Discussion:
[Xen-changelog] [xen staging] xen/arm: initialize access
p***@xen.org
2018-11-09 11:55:15 UTC
Permalink
commit 8d84e701fdc3825f65e32e34f14c0f9ccfe359e1
Author: Stefano Stabellini <***@kernel.org>
AuthorDate: Tue Nov 6 14:05:57 2018 -0800
Commit: Julien Grall <***@arm.com>
CommitDate: Fri Nov 9 11:49:40 2018 +0000

xen/arm: initialize access

Initialize variable *access before returning it back to the caller.
It makes the code a bit nicer and it is a safety certification
requirement.

M3CM Rule-9.1: The value of an object with automatic storage duration
shall not be read before it has been set

QAVerify: 2962
Signed-off-by: Stefano Stabellini <***@xilinx.com>
Acked-by: Razvan Cojocaru <***@bitdefender.com>
Acked-by: Julien Grall <***@arm.com>
CC: ***@bitdefender.com
CC: Tamas K Lengyel <***@tklengyel.com>
---
xen/arch/arm/mem_access.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/mem_access.c b/xen/arch/arm/mem_access.c
index 653d96050d..86ddb29c55 100644
--- a/xen/arch/arm/mem_access.c
+++ b/xen/arch/arm/mem_access.c
@@ -47,6 +47,7 @@ static int __p2m_get_mem_access(struct domain *d, gfn_t gfn,
};

ASSERT(p2m_is_locked(p2m));
+ *access = p2m->default_access;

/* If no setting was ever set, just return rwx. */
if ( !p2m->mem_access_enabled )
--
generated by git-patchbot for /home/xen/git/xen.git#staging

Loading...