[Xen-changelog] [xen master] tools: ipxe: Correct download error handling

[p***@xen.org]

commit 58f904c4cf9fc5a49e7807fd91cd2523fa8dd191
Author: Ian Jackson <***@eu.citrix.com>
AuthorDate: Mon Nov 5 18:40:49 2018 +0000
Commit: Ian Jackson <***@eu.citrix.com>
CommitDate: Tue Nov 6 12:15:05 2018 +0000

tools: ipxe: Correct download error handling

This shell fragment lacked set -e. So, eg if the download failed a
broken ipxe.tar.gz would be left behind.

Signed-off-by: Ian Jackson <***@eu.citrix.com>
Reviewed-by: Paul Durrant <***@citrix.com>
Tested-by: Paul Durrant <***@citrix.com>
Acked-by: Wei Liu <***@citrix.com>
---
tools/firmware/etherboot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index 3868f876ea..fd8dfdf5a7 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -33,7 +33,7 @@ $(ROM): $(ROMS)
$(MAKE) -C $D/src bin/$(*F).rom

$T:
- if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
+ set -e; if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
$(GIT) clone $(IPXE_GIT_URL) $D.git; \
(cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
$(IPXE_GIT_TAG) | gzip -n >../_$T); \
--
generated by git-patchbot for /home/xen/git/xen.git#master